Skip to content

Conversation

@stonebuzz
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35986

improve global performance when using many genericobject

When a GLPI page is loaded (depending of context) a itemtype created by genericobject can be registered at least 9 times (see on ticket page)

With 200 object -> 1800 registerType call ..

So before registerType (which done many action) check if already register in $_SESSION

Before

image

After

image

Screenshots (if appropriate):

@stonebuzz stonebuzz self-assigned this Feb 14, 2025
@stonebuzz stonebuzz merged commit 356c8af into pluginsGLPI:main Feb 26, 2025
3 checks passed
@stonebuzz stonebuzz mentioned this pull request Feb 28, 2025
3 tasks
@stonebuzz stonebuzz mentioned this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant