Add the possibility to have field itemtype onto same itemtype (recursion on itself) #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomolimo
changed the title
cedric-anne
reviewed
Sep 13, 2022
Comment on lines
-1590
to
-1596
| $search_string = json_encode($itemtype); | ||
| // Backslashes must be doubled in LIKE clause, according to MySQL documentation: | ||
| // > To search for \, specify it as \\\\; this is because the backslashes are stripped | ||
| // > once by the parser and again when the pattern match is made, | ||
| // > leaving a single backslash to be matched against. | ||
| $search_string = str_replace('\\', '\\\\', $search_string); | ||
|
|
Contributor
There was a problem hiding this comment.
This should not be reverted. It is mandatory to correctly handle itemtype using namespaces (i.e. Glpi\Socket).
| ON containers.id = fields.plugin_fields_containers_id | ||
| AND containers.is_active = 1 | ||
| WHERE containers.itemtypes LIKE '%" . $DB->escape($search_string) . "%' | ||
| WHERE containers.itemtypes LIKE '%" . $itemtype . "%' |
Contributor
|
Fixed by #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding posibility to create a dropdown on self block
Adding possibility to make a filter on different object ( ex: on computer can filter computermodels) and dropdown with computermodels data
Adding possibility to add a column on different object ( ex: make a column on computer asset, search on computermodels)
note: this change work on other asset or other data not only on computer and computermodels