fix(container): fixing the rights check #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since release 1.12.1 a bug appears from this PR #425
From Dictionnay Software form, it's impossible to add a criteria.
With super-admin profile it's OK
But with another profile and good right
It's impossible
The "Add" button disappear.
When plugin it's called from this hook
the plugin tries to find a container for the object being viewed (RuleCriteria in this case)
The hook is called from
CommonDBTM.class.phpcanEditreturntruecan EditreturnfalseWhen plugin try to find a container related to the object this line break the check process (
canEdit)Here we can check directly the arg (instead of load object), because arg is determined by
get_classfunction (which use an object)