Error when $profile->find() return an empty array #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice: Trying to access array offset on value of type null in L:\inetpub\wwwroot\glpi\plugins\fields\inc\container.class.php on line 921 if $found is empty, $first_found is null and so $first_found['right'] does not exist
cedric-anne
reviewed
Jun 22, 2021
Contributor
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
Could you please explain how to reproduce this issue in the description ?
| 'right' => ['>=', READ]]); | ||
| $first_found = array_shift($found); | ||
| if ($first_found['right'] == null || $first_found['right'] == 0) { | ||
| if (isset($first_found['right']) && ($first_found['right'] == null || $first_found['right'] == 0)) { |
Contributor
There was a problem hiding this comment.
array_shift will return null if array is empty. Checking for null value is more appropriate.
Suggested change
| if (isset($first_found['right']) && ($first_found['right'] == null || $first_found['right'] == 0)) { | |
| if ($first_found !== null && ($first_found['right'] == null || $first_found['right'] == 0)) { |
Author
|
Hello, |
Contributor
|
Fixed in #447. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: Trying to access array offset on value of type null in L:\inetpub\wwwroot\glpi\plugins\fields\inc\container.class.php on line 921
if $found is empty, $first_found is null and so $first_found['right'] does not exist
Reproduce: Load page /front/helpdesk.public.php