-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common interface for the Cachify storage classes #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thanks. I would have some minor cosmetic/pedantic suggestions, but I totally agree with the changes proposed.
Thanks for taking the time to review the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squashed the changes into 2 commits (interface + coverage), LGTM
Quality Gate passedIssues Measures |
I started to collect the least common methods with their arguments. It is now possible to guarantee a common interface by implementing Cachify_Backend in the interested classes.
I also made the overall coverage more visible and narrowed the output down to the classes (and not template-like the setup code for example):