-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antispam Bee 3 #506
Draft
florianbrinkmann
wants to merge
193
commits into
master
Choose a base branch
from
v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Antispam Bee 3 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d build processes
…tion call, as the translations are loaded from translate.wordpress.org
} | ||
$fields = []; | ||
foreach ( $_POST as $key => $value ) { | ||
if ( isset( $fields['plugin_field'] ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we rely on the order of the honeypot and the field that is replaced by it. We should not do that, and find a way to handle that independently from the order in $_POST
* Process WooCommerce reviews * Allow filtering processable comment types * Cast comment type filter to array
We support >= 7, so the 5.4 stuff is obsolete. Remove it.
* remove "lint-all" which does not exist anymore * update WPCS to 3.0 * clean up GH action and update PHP version
Behat dependencies have been updated, but it is not expected that the tests will work. Add some simple rule tests to start with.
Types are now checked at function call, so we can assume the type is always correct at time of execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.