copy meta.json on source exports #2152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, was also needed for Daisy so passing the File object instead of just the string. |
dromer
commented
Jul 22, 2025
| @@ -359,6 +360,10 @@ class DaisyExporter final : public ExporterBase { | |||
|
|
|||
| bool heavyExitCode = getExitCode(); | |||
|
|
|||
| if (heavyExitCode == 0) { | |||
There was a problem hiding this comment.
do we even need this here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am always missing the source json on these exports.
Could've gone the route of passing the temp-file object directly, but I figured doing it KISS for now.What do you think is better @timothyschoen ?