Updated main.yml to use proxy for helper packages. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the tasks for installing helper packages to use proxy variable http_proxy set in ploy.conf. This ensures that the task won't fail if proxy is to be used.
|
test_roles.py needs to be updated. Otherwise I think this is correct, but @tomster might want to take a look, since he uses/used the feature. |
|
The remaining test failures with older ansible versions seem to be unrelated, I saw them before. |
|
sorry, i completely missed this PR (a lot of github notifications end up in my spam filter...) the fix looks correct but i don't have time to test it just now. i will do that ASAP and then merge and/or get back on this. thanks for the PR! |
|
i've dropped support for older ansible versions on master, so it's safe to ignore these errors here. while i still haven't had time to bootstrap a demo instance using a proxy, the bug and its fix are rather obvious (in hindsight) so i'm merging this, as is. thanks again |
tomster
added a commit
that referenced
this pull request
Jul 26, 2015
Updated main.yml to use proxy for helper packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the task for installing helper packages to use proxy variable http_proxy set in ploy.conf.
This ensures that the task won't fail if http/https proxy is to be used.