-
Notifications
You must be signed in to change notification settings - Fork 120
Deprecate kaleido #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andrei-ng
wants to merge
8
commits into
main
Choose a base branch
from
deprecate-kaleido
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Deprecate kaleido #319
+8,327
−964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
971ae11
to
8bf7da9
Compare
6fc0105
to
e2a3776
Compare
- allow user to reuse the exporter object - use data uri for CDN case and file for offline case when generating the html for static image export - there are size restrictions when using data-uri , webdriver cannot load large data-uri files, so for offline mode, default to using html returned by to_file - added build.rs to download webdriver chromedriver/geckodriver - include example on how to use static export for json data - allow user to set browser capabilities via setter - allow user to configure html2pdf timeout - added documentation and add example for plotly_static - included new static export in plotly crate and marked kaleido as deprecated using deprecation warnings - add extra api to reuse static exporter - refactored usage of imageformat between packages - added custom CI setup for Windows as Windows GitHub Action for chrome setup is unique Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
e2a3776
to
47f3379
Compare
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
ee779a7
to
b0e81d1
Compare
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
b0e81d1
to
ce71401
Compare
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
d7da7fa
to
de794bb
Compare
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
de794bb
to
f9b4c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.