Remove 'static lifetime requirement for Plot.to_inline_html()
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfreeborn
added a commit
that referenced
this pull request
Nov 3, 2022
* Refactor examples and readme (#113) * update main readme * update plotly_kaleido readme * update readme * typo * add readme * Refactor examples and readme * update changelog * fix CI workflow * update workflows * tpyo * formatting * fix workflows * update workflows * update readme * update readme * update url * final tweaks * Remove 'static lifetime requirement for `Plot.to_inline_html()` (#115) * remove 'static lifetime requirement * update changelog * add `legend_group_title` to existing traces (#110) * feat: add legendgrouptitle too all existing traces Fixes #109 * update changelog Co-authored-by: Michael Freeborn <michaelfreeborn1@gmail.com> * Traces for Mesh3d, Image, ScatterMapbox (#88) * Add basic Mesh3D trace functionality * Add basic Image trace functionality * Add basic ScatterMapbox functionality * Fix compilation errors due to merge * Copy some setters * Fill in some more Mesh3D setters * Complete the Mesh3D setters * Complete the Image setters * Sketch idea of ImageData trait * Complete the ScatterMapbox setters * Add tests for Mesh3D * Fix cargo warnings * Make greater use of IntoIterator trait * Add tests for Image * Add tests for ScatterMapbox * Fix compilation errors * Insert _ in setter names * Run rustfmt and add line breaks to documentation * Add jupyter lab examples for Mesh3D, Image, ScatterMapbox * Update CHANGELOG * Remove setter assertions * refactoring * fix tests * formatting * add ImageData trait * add Image trace examples * add mesh3d example * rustfmt * add map example * tweak zoom data type * rustfmt * clippy * update workflows Co-authored-by: Michael Freeborn <michaelfreeborn1@gmail.com> * add plotly_image to features list * v0.8.2 Co-authored-by: Kai Howelmeyer <kai@hoewelmeyer.eu> Co-authored-by: Joel Sjögren <joelsjogren.wii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114