Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog/version bump for PR #958 #959

Merged
merged 3 commits into from
Mar 8, 2018
Merged

Changelog/version bump for PR #958 #959

merged 3 commits into from
Mar 8, 2018

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Mar 6, 2018

@cldougl

NB. version is set to 2.5.0 because the dashboard PR #946 has the same version number

@Kully
Copy link
Contributor Author

Kully commented Mar 6, 2018

@chriddyp

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [2.5.0] - UNRELEASED
### Fixed
- `import plotly.figure_factory` does not fail if `pandas` is not installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the PR where this was fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's This is fixed in the PR https://github.com/plotly/plotly.py/pull/958?
or just https://github.com/plotly/plotly.py/pull/958

@cldougl
Copy link
Member

cldougl commented Mar 8, 2018

💃

@Kully Kully merged commit 98feab6 into master Mar 8, 2018
@Kully Kully deleted the changelog-ff-crash branch March 8, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants