another api endpoint #732
Merged
another api endpoint #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriddyp looking at it now |
Kully
reviewed
Apr 12, 2017
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| ## [Unreleased] | |||
| ### Added | |||
| - offline embedded plots are now responsive to window resizing when `output_type == "div"` is set in `plotly.offline.iplot()`. | |||
| - Beta: Methods were added that wrap the API endpoint for managing Dash objects on plot.ly. The API interface is under `plotly.api.v2.dash_apps` | |||
There was a problem hiding this comment.
I think present tense sounds better here, so Methods (are added) that wrap the API endpoint ....
Kully
reviewed
Apr 12, 2017
plotly/api/v2/dash_apps.py
Outdated
|
|
||
|
|
||
| def retrieve(fid): | ||
| """Retrieve a dashboard from Plotly.""" |
There was a problem hiding this comment.
Is this supposed to say dashboard? Are dash apps just dashboards?
There was a problem hiding this comment.
woops, that's a typo. updated
Kully
reviewed
Apr 12, 2017
| @@ -0,0 +1,4 @@ | |||
| from __future__ import absolute_import | |||
|
|
|||
| from plotly.api.v2 import (dashboards, files, folders, grids, images, plot_schema, | |||
There was a problem hiding this comment.
What is the point of this file? Is this a file for the purpose of testing out our v2 stuff?
There was a problem hiding this comment.
woops didn't meant to commit that
|
lgtm 💃 |
|
💃 from me as well - after tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.