Skip to content

[2.0.0] Unify API #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 9, 2017
Merged

[2.0.0] Unify API #651

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
789ac11
Try getting the error message in response_handler
alexandresobolevski Dec 21, 2016
e98ce73
Did not mean to commit this
alexandresobolevski Dec 21, 2016
f425a4c
Always raise PlotlyRequestError
alexandresobolevski Dec 22, 2016
eb794b6
Change expected exception
alexandresobolevski Dec 22, 2016
b0b0d55
Factor out `get_config` and `get_credentials`.
theengineear Dec 22, 2016
004d312
Generalize our `PlotlyRequestError`.
theengineear Dec 27, 2016
002ab4e
Create organized api modules :tada:!
theengineear Dec 27, 2016
de51cd8
Use the new api definitions in all api calls.
theengineear Dec 27, 2016
61a1e01
Use `api.v2.plot_schema` to get GRAPH_REFERENCE.
theengineear Dec 27, 2016
78daf3c
:wrench: Allow `proxy_*` in `sign_in`.
theengineear Dec 27, 2016
73e6c6e
Use requests.compat.json instead of plain json.
theengineear Dec 29, 2016
b5311de
:dolls: Remove outdated comment.
theengineear Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always raise PlotlyRequestError
  • Loading branch information
@alexandresobolevski @theengineear
alexandresobolevski authored and theengineear committed Jan 5, 2017
commit f425a4cc12d06a8be32861aedcad542d0f308fee
8 changes: 5 additions & 3 deletions plotly/plotly/plotly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,9 +1318,11 @@ def response_handler(cls, response):
errors = parsed_response.get('errors')
message = errors[-1]['message']
except:
raise requests_exception

raise exceptions.PlotlyError(message)
# otherwise raise a generic error
raise exceptions.PlotlyRequestError(requests_exception)
else:
requests_exception.message = message
raise exceptions.PlotlyRequestError(requests_exception)

if ('content-type' in response.headers and
'json' in response.headers['content-type'] and
Expand Down