Skip to content

Refactor validators #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 82 commits into
base: release-6.1.0rc0
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
8a787b5
Add deprecation notice for orca
LiamConnors Mar 25, 2025
9dd3330
Create static-image-generation-migration.md
LiamConnors Mar 25, 2025
97168bf
Add deprecation notice
LiamConnors Mar 25, 2025
ca80cdd
Add info on changes in Plotly.py 6.1
LiamConnors Mar 25, 2025
7c76ee3
Add draft of Kaleido updates
LiamConnors Mar 25, 2025
2e0b441
Add default settings info
LiamConnors Mar 27, 2025
577329d
Make small updates and add back Orca export settings
LiamConnors Mar 27, 2025
02b31f0
Update link
LiamConnors Mar 31, 2025
3281d99
Update static-image-export.md
LiamConnors Mar 31, 2025
2cbd63c
Update migration guide for Kaleido
LiamConnors Mar 31, 2025
9855b6a
remove orca section
LiamConnors Apr 1, 2025
28e7e19
Update static-image-export.md
LiamConnors Apr 1, 2025
e8149ae
Small updates
LiamConnors Apr 1, 2025
e45d56e
Merge branch 'main' into kaleido-docs-updates
LiamConnors Apr 1, 2025
0b79a17
Update static-image-generation-migration.md
LiamConnors Apr 1, 2025
f8cad81
Merge branch 'kaleido-docs-updates' of https://github.com/plotly/plot…
LiamConnors Apr 1, 2025
f5ac772
Update doc/python/static-image-export.md
LiamConnors Apr 2, 2025
10e8f20
Update doc/python/static-image-export.md
LiamConnors Apr 2, 2025
bbac70b
Update doc/python/static-image-export.md
LiamConnors Apr 2, 2025
9ad552e
Update doc/python/static-image-export.md
LiamConnors Apr 2, 2025
c290b5f
Update doc/python/static-image-export.md
LiamConnors Apr 2, 2025
7b8061b
Update static-image-generation-migration.md
LiamConnors Apr 3, 2025
07fd630
Merge branch 'kaleido-docs-updates' of https://github.com/plotly/plot…
LiamConnors Apr 3, 2025
6ba54f3
Update static-image-export.md
LiamConnors Apr 23, 2025
30cc778
Update doc/python/static-image-generation-migration.md
LiamConnors Apr 23, 2025
9b09504
Merge branch 'main' into kaleido-docs-updates
LiamConnors Apr 28, 2025
fded494
Merge branch 'kaleido-docs-updates' of https://github.com/plotly/plot…
LiamConnors Apr 29, 2025
077a356
Add note on browsers
LiamConnors Apr 29, 2025
2821776
Merge branch 'main' into kaleido-docs-updates
LiamConnors Apr 29, 2025
9f9262b
Update doc/python/static-image-generation-migration.md
LiamConnors Apr 30, 2025
551eaa6
update install commands
LiamConnors Apr 30, 2025
b9816bd
Merge branch 'kaleido-docs-updates' of https://github.com/plotly/plot…
LiamConnors Apr 30, 2025
8a8b052
Update doc/python/static-image-export.md
LiamConnors Apr 30, 2025
fc13f1d
Update doc/python/static-image-generation-migration.md
LiamConnors Apr 30, 2025
63229fc
Update doc/python/static-image-export.md
LiamConnors Apr 30, 2025
2eeac47
Update doc/python/static-image-export.md
LiamConnors Apr 30, 2025
b42185e
Update doc/python/static-image-generation-migration.md
LiamConnors Apr 30, 2025
e753b7b
Update doc/python/static-image-generation-migration.md
LiamConnors Apr 30, 2025
9fb73a1
Update doc/python/static-image-generation-migration.md
LiamConnors Apr 30, 2025
0284d5e
Update doc/python/static-image-export.md
LiamConnors Apr 30, 2025
ff62066
Update doc/python/static-image-export.md
LiamConnors Apr 30, 2025
41d72f0
Update doc/python/static-image-export.md
LiamConnors Apr 30, 2025
a27e2a9
Update static-image-export.md
LiamConnors May 1, 2025
8e62339
Update static-image-export.md
LiamConnors May 1, 2025
b8253c4
Update static-image-generation-migration.md
LiamConnors May 1, 2025
ba8ab39
Update static-image-export.md
LiamConnors May 1, 2025
2cc67f3
Update getting-started.md
LiamConnors May 1, 2025
9be1a49
Update static-image-generation-migration.md
LiamConnors May 1, 2025
70984fb
Update _kaleido.py
LiamConnors May 2, 2025
1965279
Merge pull request #5161 from plotly/release-6.1.0rc0
emilykl May 2, 2025
2f66bf1
Update plotly/io/_kaleido.py
LiamConnors May 6, 2025
815d975
Merge pull request #5164 from plotly/docstring-updates
LiamConnors May 6, 2025
d3ba372
Merge branch 'main' into kaleido-docs-updates
LiamConnors May 6, 2025
f70d8bf
Merge pull request #5111 from plotly/kaleido-docs-updates
LiamConnors May 7, 2025
5d29c69
removing old generated validators
bmaranville May 8, 2025
b359323
write single json instead of python files
bmaranville May 8, 2025
71be168
generate validator class instances from json data
bmaranville May 8, 2025
f3b546c
use validators from ValidatorCache
bmaranville May 8, 2025
646b4b6
use validators from ValidatorCache
bmaranville May 8, 2025
03100b4
use DataValidator from ValidatorCache
bmaranville May 8, 2025
0f6040b
trace validator should be instance not class of DataValidator
bmaranville May 8, 2025
2fb4670
use validators from ValidatorCache
bmaranville May 8, 2025
ae2ad4d
use template validator from ValidatorCache
bmaranville May 8, 2025
e92cf30
allow overlaying args on derived classes
bmaranville May 8, 2025
b46cb01
add DataValidator to autogenerated instances provided by ValidatorCac…
bmaranville May 8, 2025
9f20fd9
add DataValidator to autogenerated instances provided by ValidatorCac…
bmaranville May 8, 2025
c4df7e3
add DataValidator to autogenerated instances provided by ValidatorCac…
bmaranville May 8, 2025
bc2118a
use a copy of the DataValidator in BaseFigure, with local set_uid att…
bmaranville May 8, 2025
09e0140
Merge branch 'plotly:main' into refactor-validators
bmaranville May 8, 2025
d48cbe1
update validator params store
bmaranville May 8, 2025
d3c5f92
removing _data.py in validators, DataValidator is generated from Base…
bmaranville May 8, 2025
2f26c48
Merge branch 'refactor-validators' of github.com:bmaranville/plotly.p…
bmaranville May 8, 2025
00a8d1d
DataValidator is an instance already, and is not callable
bmaranville May 8, 2025
5607de0
use heatmap colorscale validator
bmaranville May 8, 2025
a23e0b7
update documentation example to use validator from ValidatorCache
bmaranville May 8, 2025
1b72556
cleanup
bmaranville May 9, 2025
689fa16
black formatting
bmaranville May 9, 2025
d893537
black formatting
bmaranville May 9, 2025
9e033b6
revert this file - it is auto-generated
bmaranville May 9, 2025
809ccc4
cleanup
bmaranville May 9, 2025
c191427
use ValidatorCache for generated Layout validators
bmaranville May 9, 2025
c301c4a
black formatting
bmaranville May 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use DataValidator from ValidatorCache
  • Loading branch information
bmaranville committed May 8, 2025
commit 03100b44512896ff9dfeb78d47fa14cd9dd8763a
6 changes: 4 additions & 2 deletions plotly/_subplots.py
Original file line number Diff line number Diff line change
Expand Up @@ -1062,9 +1062,11 @@ def _init_subplot_domain(x_domain, y_domain):


def _subplot_type_for_trace_type(trace_type):
from plotly.validators import DataValidator
from plotly.validator_cache import ValidatorCache
DataValidator = ValidatorCache.get_validator("", "data")
# from plotly.validators import DataValidator

trace_validator = DataValidator()
trace_validator = DataValidator
if trace_type in trace_validator.class_strs_map:
# subplot_type is a trace name, find the subplot type for trace
trace = trace_validator.validate_coerce([{"type": trace_type}])[0]
Expand Down