Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove py2 from build #4357

Merged
merged 3 commits into from
Sep 15, 2023
Merged

remove py2 from build #4357

merged 3 commits into from
Sep 15, 2023

Conversation

alexcjohnson
Copy link
Collaborator

We haven't supported Py2 for a while, so we should remove the universal flag from the bdist_wheel command so we don't end up with py2 in the filename :)

alexcjohnson and others added 3 commits September 15, 2023 14:40
circleci API calls are currently not including this? Just let it slide, this doesn't seem to serve any purpose other than to tell you more about what version of the code you're using
@alexcjohnson
Copy link
Collaborator Author

whew, removed a whole bunch more Py2 junk that was still lying around - __future__ imports, a few # -*- coding: utf-8 -*- headers, some manual compatibility shims...

I didn't touch chart_studio, which still has lots of __future__ imports.

@archmoj
Copy link
Contributor

archmoj commented Sep 15, 2023

LGTM 🙏

Copy link
Member

@LiamConnors LiamConnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit 294d743 into master Sep 15, 2023
5 checks passed
@alexcjohnson alexcjohnson deleted the no-universal branch September 15, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants