Do not sort keys during json serialization #3386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3380
This PR removes the instruction to the json/orjson engines to sort dict keys during serialization. This fixes #3380 and should improve serialization performance a little.
Also, while looking at the orjson option flags, I noticed that there is a
OPT_NON_STR_KEYS
option.This would have been a better fix that what I did in #3351, so I made the change here.