Skip to content

Do not merge: CircleCI work for issue3036 #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a68ad6a
Refactoring to one JS package
Apr 8, 2021
e19d480
Update packaging
Apr 9, 2021
83e61de
Load plotly asynchronously
Apr 9, 2021
1bba54f
Fix packaging from scratch
Apr 9, 2021
01def03
Update doc
Apr 9, 2021
fc96705
Update CI
Apr 9, 2021
2ca063f
Fix setup dependencies
Apr 9, 2021
1dc74ca
Fix linter
Apr 9, 2021
8a29e75
Correct setup warning
Apr 9, 2021
ae247b0
Modernize CI
Apr 9, 2021
2f4d638
Back to lockfile v1
Apr 9, 2021
410c760
Increase executor RAM
Apr 9, 2021
7d0aaee
Install jupyterlab in tox env for packaging JS code
Apr 9, 2021
a41ab2b
Add jupyterlab in tox env of plotly pkg
Apr 9, 2021
c7e59b0
Update npm package-lock
Apr 9, 2021
ab9feef
Install jupyterlab with tox in root python
Apr 9, 2021
71fe11c
Skip building JS assets except in plotlyjs_dev_build
Apr 9, 2021
b2e5292
Condition packaged data on skip npm
Apr 9, 2021
fea5475
Fix update_package_data
Apr 9, 2021
73647ee
Reduce number of CI changes
Apr 9, 2021
191a548
Fix typo
fcollonval Apr 10, 2021
dc9c8df
Merge remote-tracking branch 'origin' into fcollonval/issue3036
jonmmease Apr 23, 2021
872f4ff
Store npm logs as build artifacts,
jonmmease Apr 23, 2021
c2a43db
Disable other CI jobs while working on dev build
jonmmease Apr 23, 2021
1f6fc01
Add JupyterLab requirement
jonmmease Apr 23, 2021
1191751
bump resource class
jonmmease Apr 23, 2021
4580723
Bump to 3.8, with jupyterlab in optional requirements.txt
jonmmease Apr 23, 2021
aadcbfa
optional requirements.txt!
jonmmease Apr 23, 2021
e99ace1
Re-enable all circleci jobs
jonmmease Apr 23, 2021
792f053
Rework chart studio job
jonmmease Apr 23, 2021
eaac04c
use venv for chart-studio job
jonmmease Apr 23, 2021
79f4c16
Activate venv for chart-studio job
jonmmease Apr 23, 2021
e57ac9e
Re-enable all circleci jobs
jonmmease Apr 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Activate venv for chart-studio job
  • Loading branch information
jonmmease committed Apr 23, 2021
commit 79f4c1617b3885e0697f19b7920ffec2b18d8f4c
33 changes: 18 additions & 15 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,10 @@ jobs:
pip install -e ./plotly
- run:
name: Tests
command: "cd packages/python/chart-studio; pytest -x chart_studio/tests/"
command: |
. venv/bin/activate
cd packages/python/chart-studio; pytest -x chart_studio/tests/

no_output_timeout: 20m

plotlyjs_dev_build:
Expand Down Expand Up @@ -417,21 +420,21 @@ workflows:
code_formatting:
jobs:
- check-code-formatting
dev_build:
jobs:
- plotlyjs_dev_build
# dev_build:
# jobs:
# - plotlyjs_dev_build

build:
jobs:
- python_36_core
- python_37_core
- python_38_core
- python_39_core
- python_36_optional
- python_37_optional
- python_38_optional
- python_39_optional
- python_38_orca
- python_37_percy
# - python_36_core
# - python_37_core
# - python_38_core
# - python_39_core
# - python_36_optional
# - python_37_optional
# - python_38_optional
# - python_39_optional
# - python_38_orca
# - python_37_percy
- python_37_chart_studio
- build-doc
# - build-doc