Skip to content

Require python 3.6 and CI maintenance #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Apr 22, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
699a925
Update setup.py to require Python>=3.6
jonmmease Apr 21, 2021
5fae5e0
Add an f-string (compatible with python>=3.6) for good measure
jonmmease Apr 21, 2021
841da65
remove pre 3.6 tests from tox and circleci
jonmmease Apr 21, 2021
4608f1e
First cut at abandoning tox
jonmmease Apr 21, 2021
3af133a
Rename plot_ly in chart_studio in ci tests
jonmmease Apr 21, 2021
028b960
Remove tox.ini files
jonmmease Apr 21, 2021
b17d6ac
Move tests with pandas/numpy dependencies to test_optional, remove th…
jonmmease Apr 21, 2021
8d83a81
Move more px tests to optional
jonmmease Apr 21, 2021
9a5c76f
increase optional timeout
jonmmease Apr 21, 2021
1014fda
Move another test with px to optional
jonmmease Apr 21, 2021
3becff8
blacken
jonmmease Apr 21, 2021
4effc46
Fix relative import
jonmmease Apr 21, 2021
87d5d05
Move dependency check tests to optional
jonmmease Apr 21, 2021
ca57ddb
more logging in optional test suite
jonmmease Apr 21, 2021
0b92a0e
Don't open browser window in matplotlylib test
jonmmease Apr 21, 2021
b759248
Add Python 3.8 and 3.9 tests
jonmmease Apr 21, 2021
8d013d1
pull dependencies for conda test case from same option requirements.t…
jonmmease Apr 21, 2021
7bdfcb0
fix indentation
jonmmease Apr 21, 2021
8d2ac6e
Activate conda environment before pip install
jonmmease Apr 21, 2021
0c85dc5
Fix 3.8/3.9 ci images
jonmmease Apr 21, 2021
bf1d1d8
Try again with pip install in conda environment
jonmmease Apr 21, 2021
6c10e9b
Set pandas plotting backend explicitly
jonmmease Apr 21, 2021
7820bbc
Fix working directory on pip install
jonmmease Apr 21, 2021
821231c
Don't fail on old versions of pandas
jonmmease Apr 21, 2021
331118e
path fix
jonmmease Apr 21, 2021
8623079
Don't fail on any exception when setting pandas backend
jonmmease Apr 21, 2021
cb0ff7c
blacken
jonmmease Apr 21, 2021
e0b6ce5
Another try
jonmmease Apr 21, 2021
94cdd99
Another try
jonmmease Apr 21, 2021
b072478
pip install into the right conda environment.
jonmmease Apr 21, 2021
1f37f16
Add psutil as optional dependency for orca tests
jonmmease Apr 21, 2021
2ac4f63
Add requirement.txt to conda ci job cache key
jonmmease Apr 21, 2021
ddb2741
Add poppler to orca tests
jonmmease Apr 21, 2021
4080677
Try reverting orca environment
jonmmease Apr 21, 2021
44f8dd6
disable non-orca tests
jonmmease Apr 21, 2021
6204354
Enable other CI tests
jonmmease Apr 21, 2021
d5d9ee6
Merge remote-tracking branch 'origin/master' into python3
jonmmease Apr 22, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'origin/master' into python3
# Conflicts:
#	.circleci/config.yml
#	packages/python/plotly/tox.ini
  • Loading branch information
jonmmease committed Apr 22, 2021
commit d5d9ee6c6f91910a8728ef52f2ed145a1f5fbe3e
2 changes: 1 addition & 1 deletion .circleci/create_conda_optional_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if [ ! -d $HOME/miniconda/envs/circle_optional ]; then
# Create environment
# PYTHON_VERSION=2.7 or 3.5
$HOME/miniconda/bin/conda create -n circle_optional --yes python=$PYTHON_VERSION \
requests nbformat six retrying psutil pandas decorator pytest mock nose poppler xarray scikit-image ipython jupyter ipykernel ipywidgets statsmodels
requests nbformat six retrying tenacity psutil pandas decorator pytest mock nose poppler xarray scikit-image ipython jupyter ipykernel ipywidgets statsmodels

# Install orca into environment
$HOME/miniconda/bin/conda install --yes -n circle_optional -c plotly plotly-orca==1.3.1
Expand Down
6 changes: 3 additions & 3 deletions doc/python/dot-plots.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ schools = ["Brown", "NYU", "Notre Dame", "Cornell", "Tufts", "Yale",
"Princeton", "U.Penn", "Stanford", "MIT", "Harvard"]
n_schools = len(schools)

men_salary = [72, 67, 73, 80, 76, 79, 84, 78, 86, 93, 94, 90, 92, 96, 94, 112]
women_salary = [92, 94, 100, 107, 112, 114, 114, 118, 119, 124, 131, 137, 141, 151, 152, 165]
women_salary = [72, 67, 73, 80, 76, 79, 84, 78, 86, 93, 94, 90, 92, 96, 94, 112]
men_salary = [92, 94, 100, 107, 112, 114, 114, 118, 119, 124, 131, 137, 141, 151, 152, 165]

df = pd.DataFrame(dict(school=schools*2, salary=men_salary + women_salary,
gender=["Men"]*n_schools + ["Women"]*n_schools))
Expand Down Expand Up @@ -158,4 +158,4 @@ fig.show()

### Reference

See https://plotly.com/python/reference/scatter/ for more information and chart attribute options!
See https://plotly.com/python/reference/scatter/ for more information and chart attribute options!
30 changes: 15 additions & 15 deletions packages/javascript/plotlywidget/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions packages/python/plotly/plotly/io/_orca.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from copy import copy
from contextlib import contextmanager

import retrying
import tenacity
from six import string_types

import _plotly_utils.utils
Expand Down Expand Up @@ -1173,11 +1173,11 @@ def validate_executable():

>>> import plotly.io as pio
>>> pio.orca.config.use_xvfb = True

You can save this configuration for use in future sessions as follows:

>>> pio.orca.config.save()
>>> pio.orca.config.save()

See https://www.x.org/releases/X11R7.6/doc/man/man1/Xvfb.1.xhtml
for more info on Xvfb
"""
Expand Down Expand Up @@ -1451,7 +1451,9 @@ def ensure_server():
orca_state["shutdown_timer"] = t


@retrying.retry(wait_random_min=5, wait_random_max=10, stop_max_delay=60000)
@tenacity.retry(
wait=tenacity.wait_random(min=5, max=10), stop=tenacity.stop_after_delay(60000),
)
def request_image_with_retrying(**kwargs):
"""
Helper method to perform an image request to a running orca server process
Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ requirements:
- setuptools
run:
- python
- retrying >=1.3.3
- tenacity >=6.2.0
- six

test:
Expand Down
4 changes: 2 additions & 2 deletions packages/python/plotly/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
###################################################

## python 2 to 3 compatibility ##
six==1.8.0
six==1.15.0

## retrying requests ##
retrying==1.3.3
tenacity>=6.2.0
2 changes: 1 addition & 1 deletion packages/python/plotly/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ def run(self):
),
("etc/jupyter/nbconfig/notebook.d", ["plotlywidget.json"]),
],
install_requires=["retrying>=1.3.3", "six"],
install_requires=["tenacity>=6.2.0", "six"],
zip_safe=False,
cmdclass=dict(
build_py=js_prerelease(versioneer_cmds["build_py"]),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
requests==2.12.4
six==1.10.0
retrying==1.3.3
tenacity==6.2.0
pytest==3.5.1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
requests==2.12.4
six==1.10.0
retrying==1.3.3
tenacity==6.2.0
pandas==0.24.2
numpy==1.19.5
xarray==0.10.9
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
requests==2.12.4
six==1.10.0
retrying==1.3.3
tenacity==6.2.0
pytest==3.5.1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
requests==2.12.4
six==1.10.0
retrying==1.3.3
tenacity==6.2.0
pandas==0.24.2
numpy==1.19.5
xarray==0.10.9
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
requests==2.25.1
six==1.15.0
retrying==1.3.3
tenacity==6.2.0
pytest==6.2.3
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
requests==2.25.1
six==1.15.0
retrying==1.3.3
tenacity==6.2.0
pandas==1.2.4
numpy==1.20.2
xarray==0.17.0
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
requests==2.25.1
six==1.15.0
retrying==1.3.3
tenacity==6.2.0
pytest==6.2.3
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
requests==2.25.1
six==1.15.0
retrying==1.3.3
tenacity==6.2.0
pandas==1.2.4
numpy==1.20.2
xarray==0.17.0
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.