Skip to content

Adds function to sample colorscales #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 10, 2021
Merged

Adds function to sample colorscales #3136

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b6a594
Adds function to sample colorscales
CarlAndersson Apr 7, 2021
1b419ad
Minor fixes
CarlAndersson May 7, 2021
e774d3f
Adds tests
CarlAndersson May 7, 2021
282ed0d
Merge remote-tracking branch 'origin/master' into colorscale-sampling
CarlAndersson May 7, 2021
fb2c139
Code formatting
CarlAndersson May 7, 2021
10be9df
Merge branch 'master' into colorscale-sampling
CarlAndersson May 10, 2021
1b8ec25
Handle string inputs with get_colorscale
CarlAndersson May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Handle string inputs with get_colorscale
  • Loading branch information
@CarlAndersson
CarlAndersson committed May 10, 2021
commit 1b8ec25f55ee4472176d79045a8bcdedc4c68b5a
8 changes: 1 addition & 7 deletions packages/python/plotly/_plotly_utils/colors/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,13 +854,7 @@ def sample_colorscale(colorscale, samplepoints, low=0.0, high=1.0, colortype="rg
validate_colorscale(colorscale)
except exceptions.PlotlyError:
if isinstance(colorscale, str):
if colorscale in PLOTLY_SCALES:
colorscale = PLOTLY_SCALES[colorscale]
else:
raise exceptions.PlotlyError(
"If your colorscale variable is a string, "
"it must be a Plotly scale."
)
colorscale = get_colorscale(colorscale)
else:
colorscale = make_colorscale(colorscale)

Expand Down