Fix missing commit info in auto-generated archives #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the repository was restructured to what it is now, the `.gitattributes` file was not updated to reflect the new paths. As a result, the current commit information is no longer inserted into `ploty/_version.py` during automatic tarball exports (as done by Github). With no information being provided implicitly by Git itself, this means the version information is entirely unavailable to the build system at `packages/python/ploty/setup.py`; this in turn results in a reported version number of `0+unknown` for builds from these archives.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the repository was restructured to what it is now, the
.gitattributesfile was not updated to reflect the new paths. As aresult, the current commit information is no longer inserted into
ploty/_version.pyduring automatic tarball exports (as done byGithub). With no information being provided implicitly by Git itself,
this means the version information is entirely unavailable to the build
system at
packages/python/ploty/setup.py; this in turn results in areported version number of
0+unknownfor builds from these archives.