Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't autoimport FigureWidget unless ipywidgets is installed and >= 7.0.0 #1425

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Don't autoimport FigureWidget unless ipywidgets is installed and >= 7.0.0 #1425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8592640
Don't autoimport FigureWidget unless ipywidgets is installed and >= 7…
jonmmease Feb 4, 2019
5bc5c6a
Remove LooseVersion and ipywidgets from graph_objs namespace
jonmmease Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions codegen/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,13 @@ def perform_codegen():
optional_figure_widget_import = """
try:
import ipywidgets
from ._figurewidget import FigureWidget
from distutils.version import LooseVersion
if LooseVersion(ipywidgets.__version__) >= LooseVersion('7.0.0'):
from ._figurewidget import FigureWidget
del LooseVersion
del ipywidgets
except ImportError:
pass

"""
root_datatype_imports.append(optional_figure_widget_import)

Expand Down
1 change: 1 addition & 0 deletions plotly/basewidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from .serializers import custom_serializers
from .version import __frontend_version__


@widgets.register
class BaseFigureWidget(BaseFigure, widgets.DOMWidget):
"""
Expand Down
7 changes: 5 additions & 2 deletions plotly/graph_objs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,13 @@

try:
import ipywidgets
from ._figurewidget import FigureWidget
from distutils.version import LooseVersion
if LooseVersion(ipywidgets.__version__) >= LooseVersion('7.0.0'):
from ._figurewidget import FigureWidget
del LooseVersion
del ipywidgets
except ImportError:
pass

from ._deprecations import (
Data, Annotations, Frames, AngularAxis, Annotation, ColorBar, Contours,
ErrorX, ErrorY, ErrorZ, Font, Legend, Line, Margin, Marker, RadialAxis,
Expand Down