Skip to content

Fix JavaScript "Error: addFrames failure" in offline html export#1152

Merged
jonmmease merged 2 commits intomasterfrom
bug_1147a
Sep 2, 2018
Merged

Fix JavaScript "Error: addFrames failure" in offline html export#1152
jonmmease merged 2 commits intomasterfrom
bug_1147a

Conversation

@jonmmease
Copy link
Copy Markdown
Contributor

Fix for "Problem 3" in #1147.

Since version 3.0, stand-alone html files/divs generated by plotly.offline.plot resulted in a harmless JavaScript error on load if no Frames were defined.

Uncaught (in promise) Error: addFrames failure: frameList must be an Array of frame definitions[object Object]
    at Object.r.addFrames (pca:73)
    at pca:79

The problem was that the no-frames case was being represented by an empty dict rather than an empty list. Also, the frames logic should not have been output at all for the empty frames case.

cc: @CiaranWelsh

@jonmmease jonmmease merged commit 07a2ab3 into master Sep 2, 2018
@nicolaskruchten nicolaskruchten deleted the bug_1147a branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant