Skip to content

feat: Make hover label triangle optional #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat: Make hover label triangle optional #7451

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e746867
implement layout.showarrow attribute
emilykl Jun 18, 2025
60f5718
add tests for layout.showarrow
emilykl Jun 18, 2025
db04896
fix hoverlabel.showarrow behavior for individual traces
emilykl Jul 22, 2025
63e44ab
fix hover label showarrow test
emilykl Jul 22, 2025
d065217
update plot-schema
emilykl Jul 22, 2025
579992e
update fx_test for new showarrow attr
emilykl Jul 22, 2025
b3258fc
handle case where trace.hoverlabel is undefined
emilykl Jul 22, 2025
23a8f8a
remove arrayOk
emilykl Jul 22, 2025
61d949e
update plot-schema
emilykl Jul 22, 2025
7c75cd2
add draftlog
emilykl Jul 23, 2025
aac31fd
typo
emilykl Jul 25, 2025
e382d2f
clearer handling of showarrow attr when hoverlabel undefined
emilykl Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle case where trace.hoverlabel is undefined
  • Loading branch information
@emilykl
emilykl committed Jul 22, 2025
commit b3258fcfc01eb9aeeabb5345d1fb8b17cc96b98e
2 changes: 1 addition & 1 deletion src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,7 +1922,7 @@ function alignHoverText(hoverLabels, rotateLabels, scaleX, scaleY) {
var offsetY = offsets.y;

var isMiddle = anchor === 'middle';
var showArrow = d.trace.hoverlabel.showarrow;
var showArrow = d.trace.hoverlabel?.showarrow;

var pathStr;
if(isMiddle) {
Expand Down