Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node 12 ci build-test #7095

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Remove node 12 ci build-test #7095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d094811
Remove node 12 test
birkskyum Aug 13, 2024
27b3cd4
remove call to node12 build test
birkskyum Aug 13, 2024
d882d9b
draftlog
birkskyum Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,6 @@ orbs:
# https://hub.docker.com/r/cimg/node/tags/

jobs:
install-and-cibuild-node12: # cibuild using node 12 & npm 6
birkskyum marked this conversation as resolved.
Show resolved Hide resolved
docker:
- image: cimg/node:12.22.7
working_directory: ~/plotly.js
steps:
- checkout
- run:
name: Set up build environment
command: .circleci/env_build.sh
- run:
name: Pretest
command: npm run pretest
- run:
name: CI-Build
command: npm run cibuild

install-and-cibuild:
docker:
- image: cimg/node:18.20.4
Expand Down Expand Up @@ -478,8 +462,6 @@ workflows:
version: 2
build-and-test:
jobs:
- install-and-cibuild-node12

- install-and-cibuild
- timezone-jasmine:
requires:
Expand Down
2 changes: 2 additions & 0 deletions draftlogs/7095_change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Drop obsolete `npm v6` installation [[#7095](https://github.com/plotly/plotly.js/pull/7095)]