Conversation
- resolved conflicts in test/jasmine/tests/hover_label_test.js
emilykl
reviewed
Apr 15, 2024
| @@ -700,9 +713,23 @@ function _hover(gd, evt, subplot, noHoverEvent, eventTarget) { | |||
| gd._spikepoints = newspikepoints; | |||
|
|
|||
| var sortHoverData = function() { | |||
Contributor
There was a problem hiding this comment.
@archmoj Could you add a comment here explaining the new sorting logic?
emilykl
approved these changes
Apr 15, 2024
Contributor
emilykl
left a comment
emilykl
left a comment
There was a problem hiding this comment.
LGTM! 💃 Shows the correct behavior when testing Liam's codepen with your changes.
emilykl
reviewed
Apr 15, 2024
| // When sorting keep the points in the main subplot at the top | ||
| // then add points in other subplots | ||
|
|
||
| var hoverDataInSubplot = hoverData.filter(function(a) { |
Contributor
There was a problem hiding this comment.
naming suggestion -- should these functions be called hoverDataInMainSubplot and hoverDataNotInMainSubplot then?
This was referenced Sep 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6960.
@plotly/plotly_js