Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double click legends when groupclick is set to toggleitem #5909

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 27, 2021

Fixes #5908.

Before vs After

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Aug 27, 2021
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 As discussed, at some point we'd like it to be that the groupclick attr controls what counts as an “item” when you click on something inside a group (a single line in the legend - usually a trace - or the whole group) and then the itemclick and itemdoubleclick attrs both say “does this event toggle that one item, toggle everything else, or do nothing?”

But this is a clear improvement so we can certainly start with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double-click items hides all when groupclick: "toggleitem"
2 participants