Skip to content

Generalize hover picking routine #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2016
Merged

Generalize hover picking routine #575

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
858a338
generalize Fx.hover to non-cartesian cases:
etpinard May 25, 2016
27683c2
store ref to ternary subplot object in fullLayout.ternary?._subplot
etpinard May 25, 2016
39b8acf
don't hack into fullLayout._plots in ternary code
etpinard May 25, 2016
92da0e3
sub ternary._ternary -> ternary._subplot
etpinard May 25, 2016
76ba24b
remove nodes inside scatterlayer in scatterternary plot step
etpinard May 27, 2016
7ff5ca9
add hover label on overlaid axis test case
etpinard May 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
store ref to ternary subplot object in fullLayout.ternary?._subplot
  • Loading branch information
@etpinard
etpinard committed May 25, 2016
commit 27683c25e692374b21f5b54c38413e575ef159e8
2 changes: 1 addition & 1 deletion src/plots/ternary/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports.plot = function plotTernary(gd) {
fullLayout
);

fullLayout[ternaryId]._ternary = ternary;
fullLayout[ternaryId]._subplot = ternary;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step to generalize how we store instances to subplot instance in fullLayout.

To note, I haven't changed all the fullLayout.scene._scene and fullLayout.geo._geo occurrences as these refs may have leaked in the wild. We should do so in v2.0.0 though.

}

ternary.plot(fullTernaryData, fullLayout, gd._promises);
Expand Down