-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add a basic smith chart #5615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add a basic smith chart #5615
Changes from 1 commit
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
9492c99
Add a dummy scattersmith trace
waxlamp 2ac5084
Modify scattersmith trace to use `re` and `im` data series
waxlamp 9366507
Perform gamma transform (with fixed z0 of unity)
waxlamp e45b7b8
Force smith chart to use radial range [0, 1]
waxlamp 6425813
Add a WIP function to draw circular "real" lines
waxlamp f7cd0b0
WIP
waxlamp 3914dc0
Display real ticks at 0.2, 0.5, 1.0, 2.0, 5.0
waxlamp 97a2224
Draw grid lines for imaginary axis
waxlamp e2f6abd
Draw imaginary axis line properly
waxlamp 7cbf9bc
Clip imaginary axis grid lines to correct angular bounds
waxlamp 7a6f86c
Draw imaginary axis tick labels
waxlamp edee054
Draw tick labels for real axis
waxlamp eeba96d
Adjust placement of real axis tick labels
waxlamp be8a250
Automatic lint fixes
waxlamp 17e60c0
Restrict points to within the smith chart area
waxlamp c821377
Fix non-automatic lint errors
waxlamp 7ee57e6
Add mock and baseline for smith chart
waxlamp dc43dd1
Add "smith_lines" baseline
waxlamp 2d6b6bf
Update smith_basic baseline
waxlamp bb444af
Add "smith_axes" mock and baseline
waxlamp 0fcb0fe
Merge remote-tracking branch 'origin/master' into smith
waxlamp 2abb96c
Update plot-schema.json
waxlamp 166199a
Fix mock validation errors
waxlamp 7346245
Add smith chart to list of subplots
waxlamp 7e67229
Force smith mocks to run at the end
waxlamp 1eb2d51
Rename "radialaxis" to "realaxis"
waxlamp 202d4a5
Rename angularaxis to imaginaryaxis
waxlamp ce8f742
Merge remote-tracking branch 'origin/master' into smith
waxlamp 7e3e69c
Disable unnecessary tick options
waxlamp 71148d2
Remove options for axis types
waxlamp 61ed436
Remove range options
waxlamp b822f04
Remove axis processing code for imaginary axis
waxlamp de9770d
Remove category options
waxlamp ed8c75a
Remove thetaunit option
waxlamp afd67e6
Remove period option
waxlamp 06e0c59
Add a scattersmith test
waxlamp 1dc00c7
Add a smith plot react test
waxlamp 135a6e5
Merge remote-tracking branch 'origin/master' into smith
waxlamp eb94f46
Fix lint errors
waxlamp dee7fc9
Update schema diff
waxlamp 7dc4ac8
Remove invalid options from mock
waxlamp 6258e63
Remove "polar" category from smith trace
waxlamp 752226b
Remove unnecessary function
waxlamp 03c78eb
Update plot description
waxlamp df36ae3
Remove `angle` and `side` options from realaxis
waxlamp 83189cf
Change "polar" to "smith"
waxlamp 090251f
Remove deprecated attributes
waxlamp eddfcde
Rename "polar" to "smith" where definitely possible
waxlamp 66ff9c1
Fix lint errors
waxlamp 7246742
Update plot-schema diff
waxlamp 5d6b528
Update baselines
waxlamp 8676ed2
Merge remote-tracking branch 'origin/master' into smith
waxlamp 316be5c
Rename polar to smith
waxlamp 43a3be8
Remove references to GL versions of smith plot
waxlamp fdf7776
Remove commented-out lines
waxlamp 8d97671
Remove commented-out code
waxlamp cb07c28
Refactor constant value lists into variables
waxlamp 2ca14f9
Remove 'backplot' layer and unused drag logic
waxlamp 5c83a18
Reuse polar/helpers.js
waxlamp 8f67a6b
Remove GL logic
waxlamp e7b47da
Use Lib.bigFont()
waxlamp 3853720
Remove logic to handle category type
waxlamp e17fcef
Remove category type logic
waxlamp 9c9806e
Remove `hoverinfo` attribute
waxlamp bb59e34
Remove `texttemplate` attributes
waxlamp 3a9648d
Add hover test for smith plot
waxlamp 736cf2c
Add smith plot test
waxlamp 33edd05
Use option fonts to control tick label rendering
waxlamp 5605f78
Change "name" attr to "smith"
waxlamp 9861349
Rename polarsublayer to smithsublayer
waxlamp 23c1aed
Add and use a `_smithlayer`
waxlamp f6c748c
Rename axis attr variables
waxlamp b26f21c
Remove `hole` attribute
waxlamp 8ace040
Remove `sector` attribute
waxlamp 021d708
Remove `gridshape` attribute
waxlamp 80de25d
Remove conditions on 'linear' type
waxlamp 6aabf51
Remove unnecessary type check
waxlamp 8351bfa
Remove unused zoom functions
waxlamp 71eedaa
Remove other drag infrastructure
waxlamp 6b0f08f
Remove the rest of the zoom infrastructure
waxlamp 0063041
Restore texttemplate feature
waxlamp 52f53ce
Merge remote-tracking branch 'origin/master' into smith
waxlamp d5ad834
Autofix lint errors
waxlamp 994bd49
Remove category axis type processing
waxlamp d25ea5a
Update schema
waxlamp e18c8e8
Enable default fonts if spec doesn't specify any
waxlamp 25c75e4
Regenerate baselines
waxlamp 600eee1
Remove unnecessary constants
waxlamp 0128452
Restore selection behavior
waxlamp c2b84ec
Fix lint errors
waxlamp d9f8b24
Add select test for scattersmith
waxlamp 14a64c6
Use light blue bgcolor for zzz_smith_line
waxlamp 6fdabfc
Use dark blue bgcolor in zzz_smith_line baseline
waxlamp 08e4e63
Use gray paper bgcolor for smith axes baseline
waxlamp 7f8cb5d
Update baselines
waxlamp 5a329da
Add text labels to baselines
waxlamp aa13b91
Add baseline for connectgaps
waxlamp ffd19e7
Add a scattersmith mock to the mock list
waxlamp 383b6f1
Add fill baseline
waxlamp 7da2e28
Add a single plot baseline
waxlamp fd0f370
Coerce `hoverformat`
waxlamp c1613b2
Add tests modeled after tests in polar
waxlamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove
texttemplate
attributes
- Loading branch information
commit bb59e347302e646503e6dc78ca42bc921d50a1ea
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep
texttemplate
feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've restored the feature in 0063041, but I don't think it is hooked up properly.