Accept symbol numbers in string format #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| k + '-dot', | ||
| n + 300, | ||
| String(n + 300), |
There was a problem hiding this comment.
OIC this is needed for coerce to work... then we also need strings up above (L222, 224) for the n and n + 100 variants.
There was a problem hiding this comment.
Good call. Done in 5b7b18f.
|
LGTM - just need the test and my one comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4460 by introducing string variant to be accepted by supply defaults and handling numeric values when passed in by an array | demo.
TODO:
@plotly/plotly_js