Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numeric sort in ternary drag #4975

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Fix numeric sort in ternary drag #4975

merged 1 commit into from
Jul 1, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 30, 2020

Similar to #4969 and #4973.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jun 30, 2020
alexcjohnson
alexcjohnson approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can't exactly tell whether and how this would break but these are definitely numbers so sure. 💃

@archmoj archmoj merged commit c925cd4 into master Jul 1, 2020
@archmoj archmoj deleted the ternary-numeric-sort branch July 1, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson