Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmapgl supplyDefaults #4950

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Fix heatmapgl supplyDefaults #4950

merged 2 commits into from
Jun 24, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 24, 2020

Fixes #4945.
Attributes namely zsmooth, xgap, ygap, xcalendar, ycalendar, zhoverformat, hoverongapsandhovertemplateused to be get into thefullDataalthough they were not part of theheatmapgl` API at the moment.

@plotly/plotly_js

 - use heatmapgl attributes not heatmap
 - only coerce valid heatmapgl attributes not heatmap attributes
@archmoj archmoj added bug something broken status: reviewable labels Jun 24, 2020
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. 💃

@archmoj archmoj merged commit 14c7632 into master Jun 24, 2020
@archmoj archmoj deleted the fix4945-heatmapgl-coerce branch June 24, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heatmapgl does not coerce its own attributes
2 participants