Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate mocks - first step #4762

Merged
merged 16 commits into from
May 1, 2020
Merged

Validate mocks - first step #4762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8c1a9d9
add mock validate test
archmoj Apr 13, 2020
a948254
adapt jasmine tests to pass the cI
archmoj Apr 14, 2020
c4a5949
validate mock 0, 1, 4, 5, 10, 11
archmoj Apr 13, 2020
64514ab
validate various funnelarea pie sunburst and treemap mocks
archmoj Apr 13, 2020
8f47a7a
validate uniformtext_* mocks
archmoj Apr 13, 2020
42e7e40
validate mesh3d, cone, isosurface & volume mocks
archmoj Apr 13, 2020
20dedaa
fixup most of title text and titlefont in mocks
archmoj Apr 13, 2020
8a56627
validate axes_breaks mocks
archmoj Apr 14, 2020
fea81e4
validate bar_* mocks
archmoj Apr 14, 2020
ecfb79a
validate various gl3d mocks
archmoj Apr 14, 2020
b3658c6
validate various gl2d mocks
archmoj Apr 14, 2020
856f2ea
validate geo_* mocks
archmoj Apr 14, 2020
117ee97
validate various mocks
archmoj Apr 14, 2020
f7a2caf
fix typo in contour legend test and update baseline
archmoj Apr 14, 2020
45c90cc
disable mock test until all validated
archmoj Apr 14, 2020
efd8518
only comment out the failing ones
archmoj May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Binary file modified test/image/baselines/contour_legend.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2,395 changes: 1,181 additions & 1,214 deletions test/image/mocks/0.json
View file
Open in desktop

Large diffs are not rendered by default.

81 changes: 9 additions & 72 deletions test/image/mocks/1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,11 +722,11 @@
}
],
"layout": {
"title": "Spectral<br>Box Plot",
"titlefont": {
"color": "",
"family": "",
"size": 18
"title": {
"text": "Spectral<br>Box Plot",
"font": {
"size": 18
}
},
"font": {
"family": "Arial, sans-serif",
Expand All @@ -738,11 +738,8 @@
"width": 600,
"height": 400,
"xaxis": {
"title": "Wavelength (nm)",
"titlefont": {
"color": "",
"family": "",
"size": 0
"title": {
"text": "Wavelength (nm)"
},
"range": [
-0.5,
Expand All @@ -753,45 +750,22 @@
1
],
"type": "category",
"rangemode": "normal",
"showgrid": false,
"zeroline": true,
"showline": false,
"autotick": false,
"nticks": 0,
"ticks": "",
"showticklabels": true,
"tick0": 0,
"dtick": 1,
"ticklen": 5,
"tickwidth": 1,
"tickcolor": "rgb(204, 204, 204)",
"tickangle": 90,
"tickfont": {
"family": "",
"size": 0,
"color": ""
},
"exponentformat": "e",
"showexponent": "all",
"gridcolor": "rgb(255, 255, 255)",
"gridwidth": 1,
"zerolinecolor": "#000",
"zerolinewidth": 1,
"linecolor": "rgba(0, 0, 0, 0)",
"linewidth": 1,
"anchor": "y",
"position": 0,
"mirror": false,
"overlaying": false,
"autorange": true
},
"yaxis": {
"title": "Response (mV)",
"titlefont": {
"color": "",
"family": "",
"size": 0
"title": {
"text": "Response (mV)"
},
"range": [
-3.919824016319688,
Expand All @@ -802,53 +776,19 @@
1
],
"type": "linear",
"rangemode": "normal",
"showgrid": true,
"zeroline": false,
"showline": false,
"autotick": true,
"nticks": 0,
"ticks": "",
"showticklabels": true,
"tick0": 0,
"dtick": 2,
"ticklen": 5,
"tickwidth": 1,
"tickcolor": "#000",
"tickangle": 0,
"tickfont": {
"family": "",
"size": 0,
"color": ""
},
"exponentformat": "none",
"showexponent": "all",
"gridcolor": "rgb(255, 255, 255)",
"gridwidth": 1.5,
"zerolinecolor": "#000",
"zerolinewidth": 1,
"linecolor": "rgba(0, 0, 0, 0)",
"linewidth": 1,
"anchor": "x",
"position": 0,
"mirror": false,
"overlaying": false,
"autorange": true
},
"legend": {
"x": 1.0402836879432624,
"y": 0.98,
"traceorder": "normal",
"font": {
"family": "",
"size": 0,
"color": ""
},
"bgcolor": "#fff",
"bordercolor": "#000",
"borderwidth": 1,
"showlegend": false
},
"margin": {
"l": 50,
"r": 20,
Expand All @@ -861,9 +801,6 @@
"plot_bgcolor": "rgb(233, 233, 233)",
"hovermode": "x",
"dragmode": "zoom",
"barmode": "stack",
"bargap": 0.2,
"bargroupgap": 0,
"boxmode": "overlay",
"separators": ".,",
"hidesources": false
Expand Down
81 changes: 9 additions & 72 deletions test/image/mocks/10.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,16 +223,15 @@
"color": "rgba(255, 0, 0, 0.5)",
"width": 2
},
"fillcolor": "rgba(255, 255, 255, 0)",
"type": "scatter"
}
],
"layout": {
"title": "Math Score Box Plots",
"titlefont": {
"color": "",
"family": "",
"size": 16
"title": {
"text": "Math Score Box Plots",
"font": {
"size": 16
}
},
"font": {
"family": "Arial, sans-serif",
Expand All @@ -244,11 +243,8 @@
"width": 600,
"height": 440,
"xaxis": {
"title": "",
"titlefont": {
"color": "",
"family": "",
"size": 0
"title": {
"text": ""
},
"range": [
-0.6575,
Expand All @@ -259,45 +255,20 @@
1
],
"type": "category",
"rangemode": "normal",
"showgrid": false,
"zeroline": false,
"showline": false,
"autotick": true,
"nticks": 0,
"ticks": "",
"showticklabels": true,
"tick0": 0,
"dtick": 1,
"ticklen": 5,
"tickwidth": 1,
"tickcolor": "#000",
"tickangle": 0,
"tickfont": {
"family": "",
"size": 0,
"color": ""
},
"exponentformat": "e",
"showexponent": "all",
"gridcolor": "rgb(255, 255, 255)",
"gridwidth": 1,
"zerolinecolor": "#000",
"zerolinewidth": 1,
"linecolor": "rgba(0, 0, 0, 0)",
"linewidth": 1,
"anchor": "y",
"position": 0,
"mirror": true,
"overlaying": false,
"autorange": true
},
"yaxis": {
"title": "Score",
"titlefont": {
"color": "",
"family": "",
"size": 0
"title": {
"text": "Score"
},
"range": [
-1.6340975059013805,
Expand All @@ -312,48 +283,18 @@
"showgrid": true,
"zeroline": false,
"showline": false,
"autotick": true,
"nticks": 0,
"ticks": "",
"showticklabels": true,
"tick0": 0,
"dtick": 2,
"ticklen": 5,
"tickwidth": 1,
"tickcolor": "#000",
"tickangle": 0,
"tickfont": {
"family": "",
"size": 0,
"color": ""
},
"exponentformat": "e",
"showexponent": "all",
"gridcolor": "rgb(204, 204, 204)",
"gridwidth": 1,
"zerolinecolor": "#000",
"zerolinewidth": 1,
"linecolor": "rgba(0, 0, 0, 0)",
"linewidth": 2,
"anchor": "x",
"position": 0,
"mirror": true,
"overlaying": false,
"autorange": true
},
"legend": {
"x": 1.1837209302325582,
"y": 1.0189344262295081,
"traceorder": "normal",
"font": {
"family": "",
"size": 0,
"color": "rgb(67, 67, 67)"
},
"bgcolor": "rgba(255, 255, 255, 0)",
"bordercolor": "rgba(0, 0, 0, 0)",
"borderwidth": 1
},
"margin": {
"l": 80,
"r": 40,
Expand All @@ -366,10 +307,6 @@
"plot_bgcolor": "rgb(255, 255, 255)",
"hovermode": "x",
"dragmode": "zoom",
"barmode": "stack",
"bargap": 0.2,
"bargroupgap": 0,
"boxmode": "overlay",
"separators": ".,",
"hidesources": false
}
Expand Down
34 changes: 15 additions & 19 deletions test/image/mocks/11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"color": "rgb(0, 0, 0)",
"thickness": 2,
"width": 6,
"opacity": 1,
"visible": true,
"traceref": "2"
},
Expand Down Expand Up @@ -53,7 +52,6 @@
"color": "rgb(0, 0, 0)",
"thickness": 2,
"width": 6,
"opacity": 1,
"visible": true,
"traceref": "3"
},
Expand All @@ -78,7 +76,6 @@
"color": "rgb(0, 0, 0)",
"thickness": 2,
"width": 6,
"opacity": 1,
"visible": true
},
"visible": false,
Expand Down Expand Up @@ -106,7 +103,6 @@
"color": "rgb(0, 0, 0)",
"thickness": 2,
"width": 6,
"opacity": 1,
"visible": true,
"traceref": "3"
},
Expand All @@ -115,11 +111,11 @@
}
],
"layout": {
"title": "Grouped Bar Chart",
"titlefont": {
"color": "",
"family": "",
"size": 16
"title": {
"text": "Grouped Bar Chart",
"font": {
"size": 16
}
},
"font": {
"family": "Arial, sans-serif",
Expand All @@ -131,11 +127,11 @@
"width": 600,
"height": 440,
"xaxis": {
"title": "Dose (mg)",
"titlefont": {
"color": "",
"family": "",
"size": 16
"title": {
"text": "Dose (mg)",
"font": {
"size": 16
}
},
"range": [
-0.5,
Expand Down Expand Up @@ -180,11 +176,11 @@
"autorange": true
},
"yaxis": {
"title": "Length",
"titlefont": {
"color": "",
"family": "",
"size": 16
"title": {
"text": "Length",
"font": {
"size": 16
}
},
"range": [
0,
Expand Down
Loading