Skip to content

Fixup rangebreaks l2p and p2l functions #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 29, 2020
Merged

Fixup rangebreaks l2p and p2l functions #4699

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8df7b6d
correct p2l for rangebreaks
archmoj Mar 28, 2020
4c5d245
ensure min < max and fix hover on reversed ranges
archmoj Mar 28, 2020
4c66949
add failing test - wrong mapping on reversed ranges
archmoj Mar 28, 2020
11c8ea2
fix rangebreaks mapping on reversed ranges - issue 4700
archmoj Mar 28, 2020
063632d
check for Infinity in rangebreak l2p
archmoj Mar 29, 2020
077b34f
make tick loop readable
archmoj Mar 29, 2020
50a2681
optimize fns a bit - pass 1
archmoj Mar 29, 2020
5876608
optimize fns more - pass 2
archmoj Mar 29, 2020
2ed2ec8
fixup test for m2
archmoj Mar 29, 2020
7511cb1
avoid reverse array twice
archmoj Mar 29, 2020
ce2e206
apply only one sign
archmoj Mar 29, 2020
18099ae
reduce if block
archmoj Mar 29, 2020
749430d
fix autorange reversed
archmoj Mar 29, 2020
ff5db2b
add new hover tests
archmoj Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check for Infinity in rangebreak l2p
  • Loading branch information
@archmoj
archmoj committed Mar 29, 2020
commit 063632d08e21d4d685bc700f2a3d53e29ce8ffb9
9 changes: 6 additions & 3 deletions src/plots/cartesian/set_convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,10 @@ module.exports = function setConvert(ax, fullLayout) {
break;
}
}
return _l2p(v, (isY ? -1 : 1) * ax._m2, ax._B[q]);
var b2 = ax._B[q] || 0;
if(!isFinite(b2)) return 0; // avoid NaN translate e.g. in positionLabels if one keep zooming exactly into a break

return _l2p(v, (isY ? -1 : 1) * ax._m2, b2);
};

p2l = function(px) {
Expand All @@ -242,8 +245,8 @@ module.exports = function setConvert(ax, fullLayout) {
if(pos < brk.pmin) break;
if(pos > brk.pmax) q = nextI;
}

return _p2l(px, (isY ? -1 : 1) * ax._m2, ax._B[q]);
var b2 = ax._B[q];
return _p2l(px, (isY ? -1 : 1) * ax._m2, b2);
};
}

Expand Down