Skip to content

fix for tweaking visible attribute of treemap pathbar #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2020
Merged

fix for tweaking visible attribute of treemap pathbar #4516

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
326cb04
remove invisible pathbar
archmoj Jan 23, 2020
838d1c3
move pathbar.remove call after pathbar.draw
archmoj Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
move pathbar.remove call after pathbar.draw
  • Loading branch information
@archmoj
archmoj committed Jan 27, 2020
commit 838d1c39c076afca631b42fdfe208fc052fe7434
6 changes: 2 additions & 4 deletions src/traces/treemap/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ function plotOne(gd, cd, element, transitionOpts) {
return;
}

if(!trace.pathbar.visible) {
selAncestors.remove();
}

var isRoot = helpers.isHierarchyRoot(entry);
var hasTransition = !fullLayout.uniformtext.mode && helpers.hasTransition(transitionOpts);

Expand Down Expand Up @@ -631,5 +627,7 @@ function plotOne(gd, cd, element, transitionOpts) {
hasTransition: hasTransition,
strTransform: strTransform
});
} else {
selAncestors.remove();
}
}