Skip to content

Fix trace-type update calls on mapbox subplots #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2019
Merged

Fix trace-type update calls on mapbox subplots #4295

merged 2 commits into from
Oct 22, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard added bug something broken status: reviewable labels Oct 22, 2019
archmoj
archmoj reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard thanks very much for the PR.
Please find my question below.

@archmoj
Copy link
Contributor

archmoj commented Oct 22, 2019

Nicely done.
💃

@etpinard etpinard merged commit 41899b1 into master Oct 22, 2019
@etpinard etpinard deleted the mapbox-restyle-trace-type-FIX branch October 22, 2019 19:16
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@archmoj archmoj archmoj left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react()ing from scattermapbox to densitymapbox and back
2 participants
@etpinard @archmoj