Guard against mirrored+automargin anchor:'free' axes #4273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- anchor:'free' axes don't draw mirror ticks, so they never need to contribute to the automargin push
|
@etpinard Thanks very much for following this issue and the PR. |
archmoj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
anchor:'free'axes don't draw mirror ticks, so they never need to contribute to the automargin push and most importantly they don't getax._anchorAxisfilled in (which lead to this bug).before (1.50.0): https://codepen.io/etpinard/pen/mddVJxQ?editors=1010
before before (1.49.5): https://codepen.io/etpinard/pen/QWWybrw?editors=1010
after: https://codepen.io/etpinard/pen/OJJMyMP?editors=1010 (noticed also legend fixup from #4160)
To go in
v1.50.1- cc @archmoj