Fix "layout first" transition race condition #4262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make testing `invocationOrder` possible, along side "did get called" vs "did not get called" checks - adapt assertSpies calls that checked arguments from multiple calls of a given spy, now each "expectations" item corresponds to one function call
- this will help lock down a fix for: #4251
... to remove "jump" caused by transitionTraces()
|
Excellent. |
|
Thanks for the review @archmoj - note that the changes here might add some "flakiness" to the |
Yes. I noticed one test failed the first time. But then it passed the second time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4251
before: https://codepen.io/nicolaskruchten/pen/WNNeZgz?editors=0010
after: https://codepen.io/etpinard/pen/rNNVepY?editors=0010
cc @plotly/plotly_js