Skip to content

Do not disable scrollZoom scroll{Width,Height} > client{Width,Height} #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Do not disable scrollZoom scroll{Width,Height} > client{Width,Height} #3424

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc33622
NEW - Issue #2371: Not disabling scrollZoom
marfoldi Oct 9, 2018
00aa9c8
fix lint
etpinard Jan 9, 2019
1314f2f
Merge branch 'master' into scrollzoom-patch
etpinard Jan 9, 2019
3ee0798
add responsize + scrollZoom test
etpinard Jan 15, 2019
09e0a5d
add scollZoom on scrollable page test
etpinard Jan 15, 2019
8969726
fix scrollZoom test cleanup
etpinard Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@etpinard
etpinard committed Jan 9, 2019
commit 00aa9c87d700c8bca0f40fa2ae34df92fc77d4bc
2 changes: 0 additions & 2 deletions src/plots/cartesian/dragbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,6 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
return;
}

var pc = gd.querySelector('.plotly');

recomputeAxisLists();

clearTimeout(redrawTimer);
Expand Down