-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2951 contrasting pie and bar inside text #3130
Commits on Oct 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 58be4f4 - Browse repository at this point
Copy the full SHA 58be4f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cabd0be - Browse repository at this point
Copy the full SHA cabd0beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 487f73e - Browse repository at this point
Copy the full SHA 487f73eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8f2af - Browse repository at this point
Copy the full SHA 6c8f2afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b02d36 - Browse repository at this point
Copy the full SHA 4b02d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66e26db - Browse repository at this point
Copy the full SHA 66e26dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66fc665 - Browse repository at this point
Copy the full SHA 66fc665View commit details -
Fix style of bar 'outside' labels being pushed 'inside' [2951]
- Bar text labels specified as `textposition: outside` being pushed `inside` (to avoid collisions with bars stacked on top) were not styled as inside labels.
Configuration menu - View commit details
-
Copy full SHA for df0d6c3 - Browse repository at this point
Copy the full SHA df0d6c3View commit details -
Fix baseline image differences resulting from parallel work [2951]
- Parallel work being pie titles and 3d tick adjustments.
Configuration menu - View commit details
-
Copy full SHA for d2dbd28 - Browse repository at this point
Copy the full SHA d2dbd28View commit details -
Retain bar text styles throughout selection as well [2951]
- Note: even before the introduction of defaulting to contrasting colors for inside text labels, font inheritance wasn't working throughout selection.
Configuration menu - View commit details
-
Copy full SHA for e26bc50 - Browse repository at this point
Copy the full SHA e26bc50View commit details -
Test that bar opacity is considered for contrasting text color [2951]
- Test ensures a bar's color opacity is taken into account when calculating a contrasting inside text color.
Configuration menu - View commit details
-
Copy full SHA for 172e3e9 - Browse repository at this point
Copy the full SHA 172e3e9View commit details -
Move rgb conversion into assert methods for bar and pie tests [2951]
- Reason: both reading and writing assert statements was more cumbersome before because the conversion of colors into their rgb form had to be done in client code that called the font color assert functions.
Configuration menu - View commit details
-
Copy full SHA for 2b3a78b - Browse repository at this point
Copy the full SHA 2b3a78bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bc3aa2 - Browse repository at this point
Copy the full SHA 3bc3aa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61b9d50 - Browse repository at this point
Copy the full SHA 61b9d50View commit details
Commits on Oct 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a27d278 - Browse repository at this point
Copy the full SHA a27d278View commit details -
Test contrasting inside text colors for standard pie colors [2951]
- Standard pie colors means no marker colors set explicitly.
Configuration menu - View commit details
-
Copy full SHA for 3ccc68b - Browse repository at this point
Copy the full SHA 3ccc68bView commit details -
Update baseline for mathjax.json [2951]
- Reason: calculation of inside text color when bar has no explicit marker color set has been fixed in a previous commit.
Configuration menu - View commit details
-
Copy full SHA for 69b35b5 - Browse repository at this point
Copy the full SHA 69b35b5View commit details