Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2951 contrasting pie and bar inside text #3130

Merged
merged 17 commits into from
Oct 25, 2018
Merged

2951 contrasting pie and bar inside text #3130

merged 17 commits into from
Oct 25, 2018

Commits on Oct 19, 2018

  1. Correct typo in a pie attribute description

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    58be4f4 View commit details
    Browse the repository at this point in the history

  2. Fix minor typos in pie_test.js

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    cabd0be View commit details
    Browse the repository at this point in the history

  3. Use contrasting inside text color for pie by default [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    487f73e View commit details
    Browse the repository at this point in the history

  4. Use contrasting inside text color for bar by default [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    6c8f2af View commit details
    Browse the repository at this point in the history

  5. Update pie baselines b/c inside text defaults to contrasting now [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    4b02d36 View commit details
    Browse the repository at this point in the history

  6. Update bar baselines b/c inside text defaults to contrasting now [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    66e26db View commit details
    Browse the repository at this point in the history

  7. Make pie font properties arrayOk [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    66fc665 View commit details
    Browse the repository at this point in the history

  8. Fix style of bar 'outside' labels being pushed 'inside' [2951] 

    - Bar text labels specified as `textposition: outside` being pushed
  `inside` (to avoid collisions with bars stacked on top) were not
  styled as inside labels.
    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    df0d6c3 View commit details
    Browse the repository at this point in the history

  9. Fix baseline image differences resulting from parallel work [2951] 

    - Parallel work being pie titles and 3d tick adjustments.
    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    d2dbd28 View commit details
    Browse the repository at this point in the history

  10. Retain bar text styles throughout selection as well [2951] 

    - Note: even before the introduction of defaulting to
  contrasting colors for inside text labels, font
  inheritance wasn't working throughout selection.
    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    e26bc50 View commit details
    Browse the repository at this point in the history

  11. Test that bar opacity is considered for contrasting text color [2951] 

    - Test ensures a bar's color opacity is taken into account when
  calculating a contrasting inside text color.
    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    172e3e9 View commit details
    Browse the repository at this point in the history

  12. Move rgb conversion into assert methods for bar and pie tests [2951] 

    - Reason: both reading and writing assert statements was more
  cumbersome before because the conversion of colors into their
  rgb form had to be done in client code that called the font color
  assert functions.
    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    2b3a78b View commit details
    Browse the repository at this point in the history

  13. Improve comment in bar/defaults.js [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    3bc3aa2 View commit details
    Browse the repository at this point in the history

  14. Improve some variable names in pie/plot.js [2951]

    @rmoestl
    rmoestl committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    61b9d50 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. Fix contrasting text color for bars without explicit marker color [2951]

    @rmoestl
    rmoestl committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    a27d278 View commit details
    Browse the repository at this point in the history

  2. Test contrasting inside text colors for standard pie colors [2951] 

    - Standard pie colors means no marker colors set explicitly.
    @rmoestl
    rmoestl committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    3ccc68b View commit details
    Browse the repository at this point in the history

  3. Update baseline for mathjax.json [2951] 

    - Reason: calculation of inside text color when bar has no
  explicit marker color set has been fixed in a previous commit.
    @rmoestl
    rmoestl committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    69b35b5 View commit details
    Browse the repository at this point in the history