Skip to content

Remove the performance overhead of showLink property #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2017
Merged

Remove the performance overhead of showLink property #1557

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5a26a4
Do nothing when showLink is set to be false
hy9be Apr 5, 2017
72a604c
Update unit test for showLink
hy9be Apr 5, 2017
69bc864
Remove spaces as the CI check returns error
hy9be Apr 5, 2017
5bd4095
Handle showSource config
hy9be Apr 6, 2017
7636cb5
Change the OR conditon to AND for triggering addLinks logic
Apr 6, 2017
603656c
Add comments
hy9be Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ plots.previousPromises = function(gd) {
* Add source links to your graph inside the 'showSources' config argument.
*/
plots.addLinks = function(gd) {
if(gd._context.showLink === false) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could break graphs that have the showSources config option set as it is called below.

So, replacing this line with something like:

if(!gd._context.showLink || !gd._context.showSources) return;

would be safer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks!


var fullLayout = gd._fullLayout;

var linkContainer = fullLayout._paper
Expand Down
6 changes: 1 addition & 5 deletions test/jasmine/tests/config_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,7 @@ describe('config argument', function() {

var link = document.getElementsByClassName('js-plot-link-container')[0];

expect(link.textContent).toBe('');

var bBox = link.getBoundingClientRect();
expect(bBox.width).toBe(0);
expect(bBox.height).toBe(0);
expect(link).toBeUndefined();
});

it('should display a link when true', function() {
Expand Down