Merge pull request #6893 from robbtraister/fix-textinfo-NPE

Fix resizing `pie` like traces when `textinfo` is set to "none"
plotly · Mar 6, 2024 · 67ddd7a · 67ddd7a
2 parents cf8bfad + 3a9aa1b
commit 67ddd7a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/draftlogs/6893_fix.md b/draftlogs/6893_fix.md
@@ -0,0 +1 @@
+- Fix possible NPE when `textinfo: "none"` for pie and funnelarea traces
diff --git a/src/traces/funnelarea/defaults.js b/src/traces/funnelarea/defaults.js
@@ -55,6 +55,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
             moduleHasTextangle: false,
             moduleHasInsideanchor: false
         });
+    } else if(textInfo === 'none') {
+        coerce('textposition', 'none');
     }
 
     handleDomainDefaults(traceOut, layout, coerce);

diff --git a/src/traces/pie/defaults.js b/src/traces/pie/defaults.js
@@ -111,6 +111,8 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
         if(textposition === 'inside' || textposition === 'auto' || Array.isArray(textposition)) {
             coerce('insidetextorientation');
         }
+    } else if(textInfo === 'none') {
+        coerce('textposition', 'none');
     }
 
     handleDomainDefaults(traceOut, layout, coerce);