use correct non-vectorized version of logical and#250
use correct non-vectorized version of logical and#250alexcjohnson merged 1 commit intoplotly:masterfrom daattali:master
Conversation
|
|
||
| # ensure that assets_folder is neither NULL nor character(0) | ||
| if (!(is.null(private$assets_folder)) & length(private$assets_folder) != 0) { | ||
| if (!(is.null(private$assets_folder)) && length(private$assets_folder) != 0) { |
There was a problem hiding this comment.
Does this change have any observable consequences (which we should lock down with a test), or is it just fixing poor practice that nonetheless happens to work?
There was a problem hiding this comment.
As long as private$assets_folder is a single value rather than a vector/list, there should be no behavioural change. From my understanding, assets_folder should be a single value, but I don't see any checks for it so I'm not sure what currently happens when you pass in a vector. I may have been too hasty in this PR because I don't actually know for sure that assets_folder needs to be a single string
There was a problem hiding this comment.
Yep, should be a single string. FWIW here's the docstring for the corresponding param in Python
|
Ah shoot, didn't notice the base branch here is |
2 participants
No description provided.