Add show_undo_redo parameter to Dash for R #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -305,6 +311,7 @@ Dash <- R6::R6Class( | |||
| self$config$requests_pathname_prefix <- resolvePrefix(requests_pathname_prefix, "DASH_REQUESTS_PATHNAME_PREFIX", url_base_pathname) | |||
| self$config$external_scripts <- external_scripts | |||
| self$config$external_stylesheets <- external_stylesheets | |||
| self$config$show_undo_redo <- show_undo_redo | |||
There was a problem hiding this comment.
Ah ok - you're calling to_JSON(self$config) for the _dash-config section of the index, so putting this into self$config is enough to get it included in the index. That probably means there's too much stuff being shoved in there. Doesn't have to be addressed now, feel free to make a new issue for it, but on the Py side we explicitly set what makes its way to the front end here
alexcjohnson
approved these changes
Apr 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to enable support for displaying the "undo" and "redo" button to step through the history of the app state for parity with Dash for Python. A simple integration test is also added to test functionality.
The "undo" button will appear like this:
... and the "redo" button will appear like this:
