fix NA case

plotly · Nov 1, 2019 · 2bec8dc · 2bec8dc
1 parent 206e0f8
commit 2bec8dc
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/R/dash.R b/R/dash.R
@@ -647,17 +647,17 @@ Dash <- R6::R6Class(
       }
 
       getServerParam <- function(value, type, default) {
-        if (is.na(value))
+        if (length(value) == 0 || is.na(value))
           return(default)
-        if (!is.null(value) && type %in% c("double", "integer") && value < 0)
+        if (type %in% c("double", "integer") && value < 0)
           return(default)
-        if (!is.null(value) && toupper(value) %in% c("TRUE", "FALSE"))
+        if (toupper(value) %in% c("TRUE", "FALSE"))
           value <- as.logical(toupper(value))
         if (type == "integer")
           value <- as.integer(value)
         if (type == "double")
           value <- as.double(value)        
-        if (value != "" && length(value) != 0 && typeof(value) == type && !is.na(value)) {
+        if (value != "" && typeof(value) == type) {
           return(value)
         } else {
           return(default)