Callback map sharing#789
Closed
endremborza wants to merge 14 commits intoplotly:devfrom
endremborza:callback-map-sharing
Closed
Callback map sharing#789endremborza wants to merge 14 commits intoplotly:devfrom endremborza:callback-map-sharing
endremborza wants to merge 14 commits intoplotly:devfrom
endremborza:callback-map-sharing
Conversation
Collaborator
|
Thanks for advancing the discussion with this POC @endremborza - I'm going to close this as it's become stale, but feel free to follow up in #787 if there are further use cases not addressed or awkward using #1103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! this is the idea referenced in #787 I thought I might as well show you what I'm on about. This gives me the chance to solve issue 2 there.
There is a lot here, but in the end, there is no significant change to currently running and tested code. On the other hand the new functionality can only be tested locally yet. ( circleci/python:#.#-stretch-node-browsers does not have a redis server set up, so i expect the ci tests to break. sorry for that, if this direction is approved, that obviously needs to be fixed)
I am merely suggesting, that this is a possible way towards the the feature of being able to dynamically add interactive elements in dash, which I find to be quite powerful. I'm working on a few projects involving dash, and all of them would greatly benefit from something like this, so if you have suggestions or some ideas how this can evolve into something that can be merged, I'm willing to put in the work.
Contributor Checklist
validate_callback_outputfunction needed to be moved from@staticmethodto top level function to allow dill pickling. it is not used anywhere elseRedisDictclass added and unit tested to optionally replace the dict type of callback_map