Repository navigation
Conversation
Visual snapshots are now captured locally by dash.testing (real browser screenshots into NITPIX_SNAPSHOT_DIR, one PNG per width) and diffed in CI by plotly/nitpix: baselines live on the nitpix-baselines orphan branch, PRs get a review comment with before/after/diff images and a nitpix/visual commit status, and changes are approved by commenting "/nitpix approve" — no test-matrix re-run needed. - dash/testing/browser.py: percy_snapshot() keeps its name and signature (public API) but saves PNGs locally instead of calling the Percy SDK. convert_canvases is now a no-op: real screenshots capture canvases. - testing.yml: drop PERCY_* env, percy-exec wrapper and percy-finalize; snapshot-producing jobs (test-main, html-test, dcc-test, 3.12 leg only) upload nitpix-snapshots-* artifacts instead. - nitpix.yml (new): workflow_run diff/report job in base-repo context, so fork and Dependabot PRs are fully supported — the old percy/dash placeholder-status hack in post-test-status.yml is removed. - nitpix-approve.yml (new): handles /nitpix approve comments. - table-visual-test still uses percy-storybook (separate token/mechanism); converting it is a follow-up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
# Conflicts: # .github/workflows/testing.yml
Dash performance benchmarks✅ all within thresholds
growth = late-third / early-third per-op time; ~1 is flat, a large value means the per-op cost scales with accumulated state. machine scale vs baseline: 0.68x - divided out of the baseline ratios so they compare like for like (the absolute warn/fail ceilings are left un-scaled); calibrated on |
|
camdecoster
left a comment
There was a problem hiding this comment.
Could you add an update to the changelog? Some downstream users might be relying on Dash installing percy.
Do you think a test should be added to verify the snapshot pipeline is working? Right now, if a call to nitpix fails, there's no feedback.



Visual snapshots are now captured locally by dash.testing (real browser screenshots into NITPIX_SNAPSHOT_DIR, one PNG per width) and diffed in CI by plotly/nitpix: baselines live on the nitpix-baselines orphan branch, PRs get a review comment with before/after/diff images and a nitpix/visual commit status, and changes are approved by commenting "/nitpix approve" — no test-matrix re-run needed.