-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unminified components bundle support. #369
Conversation
This looks great! I think we should actually turn this feature on when a user is in a global "dev" mode, where they would also turn on the Dash Dev Tools features. I think an argument to I don't have a method in Dev Tools just yet. Maybe we should change |
@rmarren1 So you want to combine the flag to serve the dev bundle and activate the devtools ? It make sense because the stacktraces will be much better with dev bundles. I think we should call the keyword argument |
Yeah either of those sound good. Yeah the stack traces are generally unreadable for the production bundles, so Dev tools should definitely depend on them |
One issue with this is that users will accidentally deploy with For some more context, see the |
For the same reason @chriddyp mentionned, I don't really like the argument in the constructor for this (and hot-reload). I think these arguments could very well be in |
@chriddyp I made the change to |
💃 looks good to me! |
I like the approach of pushing dev mode activation away from Dash's constructor. I also think it's important that we don't bake dev-mode specific setup logic into What about having a separate Dash method like If we wanted to do that, this could be a separate PR though. |
437dd33
to
72a0db7
Compare
625db7a
to
7b3d319
Compare
a1cf21e
to
b5fe3c8
Compare
I released the component suites bundles, when I tried to load them from unpkg it failed because of the name change from Fix:
|
dash/dash.py
Outdated
served by wsgi and you want to activate the dev tools, you can call | ||
this method out of `__main__`. | ||
|
||
:param debug: If false no tools will be activated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add If True, then all of the other dev tool settings will be True unless specifically overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for your patience on this one!
b5fe3c8
to
81d2220
Compare
Add support for serving unminified component bundles. Resolves #313.
Enable with:
The components libs needs a new key in the their
_js_dist
:dev_package_path
.