Skip to content

fixing issue with tooltip styling #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

fixing issue with tooltip styling #3271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f393471
fixing issue with tooltip styling
BSd3v Apr 11, 2025
c108a4d
Merge branch 'dev' into dev
T4rk1n Apr 14, 2025
8ca5215
wait for element grrs002
T4rk1n Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions components/dash-core-components/src/components/Tooltip.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React from 'react';
import PropTypes from 'prop-types';

import _JSXStyle from 'styled-jsx/style'; // eslint-disable-line no-unused-vars
import LoadingElement from '../utils/LoadingElement';

/**
* A tooltip with an absolute position.
Expand All @@ -27,9 +26,9 @@ const Tooltip = ({
return (
<>
<div className="dcc-tooltip-bounding-box">
<LoadingElement
elementType="span"
<div
className={`hover hover-${direction}`}
data-dash-is-loading={is_loading}
>
<span
id={id}
Expand All @@ -42,7 +41,7 @@ const Tooltip = ({
props.children
)}
</span>
</LoadingElement>
</div>
</div>
<style jsx>{`
.dcc-tooltip-bounding-box {
Expand Down
4 changes: 2 additions & 2 deletions components/dash-core-components/tests/integration/graph/test_graph_responsive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def update_figures(n_clicks):
dash_dcc.wait_for_text_to_equal("#generate-btn", "Generate Figures")
dash_dcc.find_element("#generate-btn").click()
dash_dcc.wait_for_text_to_equal("#bounding-output", "loaded")
dash_dcc.find_element(".dash-graph .js-plotly-plot.dash-graph--pending")
dash_dcc.find_element(".dash-graph .js-plotly-plot:not(.dash-graph--pending)")
dash_dcc.wait_for_element(".dash-graph .js-plotly-plot.dash-graph--pending")
dash_dcc.wait_for_element(".dash-graph .js-plotly-plot:not(.dash-graph--pending)")
dash_dcc.find_element("#bounding-btn").click()
dash_dcc.wait_for_text_to_equal("#bounding-output", "true")