Fix clientside pattern matching with a dot in the id. #3168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
requested review from
alexcjohnson,
emilykl,
gvwilson and
ndrezn
as code owners
gvwilson
approved these changes
Feb 14, 2025
Contributor
gvwilson
left a comment
gvwilson
left a comment
There was a problem hiding this comment.
one small suggestion but 👍 to merge
| componentId = JSON.parse(componentId); | ||
| const trig = triggered[0]; | ||
| let componentId; | ||
| if (trig.startsWith('{')) { |
Contributor
There was a problem hiding this comment.
worth stripping whitespace from triggered[0] before this test?
Contributor
Author
There was a problem hiding this comment.
No, we create this composite, there is no whitespace possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3163