Skip to content

Conversation

@KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Dec 11, 2024

This PR fixes a bug where a Graph with an invalid figure prop (for example, figure=None) would remain broken even after being updated to a valid figure.

See the integration test for an example Dash app that is fixed here.

Fixes https://github.com/plotly/notebook-to-app/issues/2065

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@KoolADE85 KoolADE85 force-pushed the bugfix/graphs-with-empty-figure branch from a620a16 to 2a640fb Compare December 11, 2024 01:30
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, just add a changelog entry.

@KoolADE85 KoolADE85 merged commit 7ba267b into dev Dec 11, 2024
3 checks passed
@AnnMarieW
Copy link
Collaborator

closes #2992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants